-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add feature to automatically remove supervisor based on retention period #11200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
server/src/main/java/org/apache/druid/server/coordinator/duty/KillSupervisors.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.druid.server.coordinator.duty; | ||
|
|
||
| import com.google.common.base.Preconditions; | ||
| import com.google.inject.Inject; | ||
| import org.apache.druid.java.util.common.logger.Logger; | ||
| import org.apache.druid.java.util.emitter.service.ServiceEmitter; | ||
| import org.apache.druid.java.util.emitter.service.ServiceMetricEvent; | ||
| import org.apache.druid.metadata.MetadataSupervisorManager; | ||
| import org.apache.druid.server.coordinator.DruidCoordinatorConfig; | ||
| import org.apache.druid.server.coordinator.DruidCoordinatorRuntimeParams; | ||
|
|
||
| /** | ||
| * CoordinatorDuty for automatic deletion of terminated supervisors from the supervisor table in metadata storage. | ||
| */ | ||
| public class KillSupervisors implements CoordinatorDuty | ||
| { | ||
| private static final Logger log = new Logger(KillSupervisors.class); | ||
|
|
||
| private final long period; | ||
| private final long retainDuration; | ||
| private long lastKillTime = 0; | ||
|
|
||
| private final MetadataSupervisorManager metadataSupervisorManager; | ||
|
|
||
| @Inject | ||
| public KillSupervisors( | ||
| DruidCoordinatorConfig config, | ||
| MetadataSupervisorManager metadataSupervisorManager | ||
| ) | ||
| { | ||
| this.metadataSupervisorManager = metadataSupervisorManager; | ||
| this.period = config.getCoordinatorSupervisorKillPeriod().getMillis(); | ||
| Preconditions.checkArgument( | ||
| this.period >= config.getCoordinatorMetadataStoreManagementPeriod().getMillis(), | ||
| "Coordinator supervisor kill period must be >= druid.coordinator.period.metadataStoreManagementPeriod" | ||
| ); | ||
| this.retainDuration = config.getCoordinatorSupervisorKillDurationToRetain().getMillis(); | ||
| Preconditions.checkArgument(this.retainDuration >= 0, "Coordinator supervisor kill retainDuration must be >= 0"); | ||
| log.debug( | ||
| "Supervisor Kill Task scheduling enabled with period [%s], retainDuration [%s]", | ||
| this.period, | ||
| this.retainDuration | ||
| ); | ||
| } | ||
|
|
||
| @Override | ||
| public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params) | ||
| { | ||
| if ((lastKillTime + period) < System.currentTimeMillis()) { | ||
| lastKillTime = System.currentTimeMillis(); | ||
|
|
||
| long timestamp = System.currentTimeMillis() - retainDuration; | ||
| int supervisorRemoved = metadataSupervisorManager.removeTerminatedSupervisorsOlderThan(timestamp); | ||
| ServiceEmitter emitter = params.getEmitter(); | ||
| emitter.emit( | ||
| new ServiceMetricEvent.Builder().build( | ||
| "metadata/kill/supervisor/count", | ||
| supervisorRemoved | ||
| ) | ||
| ); | ||
| log.info("Finished running KillSupervisors duty. Removed %,d supervisor", supervisorRemoved); | ||
| } | ||
| return params; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,6 +176,8 @@ public void setUp() throws Exception | |
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| 10, | ||
| new Duration("PT0s") | ||
| ); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javadocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done