Skip to content

Upgrade jetty version#11207

Merged
asdf2014 merged 1 commit intoapache:masterfrom
a2l007:jettyu
May 6, 2021
Merged

Upgrade jetty version#11207
asdf2014 merged 1 commit intoapache:masterfrom
a2l007:jettyu

Conversation

@a2l007
Copy link
Copy Markdown
Contributor

@a2l007 a2l007 commented May 5, 2021

Fixes #11206.

Upgrade jetty version to 9.4.40. This version also fixes a regression issue with version 9.4.39 which causes intermittent failures for large queries. Please see attached issue for more details.


This PR has:

  • been self-reviewed.
  • added or updated version, license, or notice information in licenses.yaml
  • been tested in a test Druid cluster.

@clintropolis clintropolis added this to the 0.21.1 milestone May 5, 2021
@clintropolis
Copy link
Copy Markdown
Member

I've observed this error as well, I've tagged with 0.21.1 to go along with the docker fix, since this is regression for the version bump which was added in 0.21.

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Reading the upstream issue it seems like this might be very hard to reproduce in a test since it sounds sensitive to internal buffer states, so I think it is ok in this case to not have a test case for this regression.

@a2l007
Copy link
Copy Markdown
Contributor Author

a2l007 commented May 5, 2021

Thanks for the review. Given the intermittent nature of this issue, I couldn't get a test case to reproduce this issue consistently.

Copy link
Copy Markdown
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asdf2014 asdf2014 merged commit ac95f99 into apache:master May 6, 2021
clintropolis pushed a commit to clintropolis/druid that referenced this pull request May 6, 2021
clintropolis added a commit that referenced this pull request May 7, 2021
Co-authored-by: Atul Mohan <atulmohan.mec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent query failures with Channel Disconnected exception

4 participants