Use the proper FileSystems for writing segments and caching jars. (for issue #1116)#1121
Merged
fjy merged 1 commit intoapache:masterfrom Feb 25, 2015
Merged
Use the proper FileSystems for writing segments and caching jars. (for issue #1116)#1121fjy merged 1 commit intoapache:masterfrom
fjy merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
FYI: #1119 That PR allows native java URL.openStream() to work on HDFS and S3/S3N |
fjy
added a commit
that referenced
this pull request
Feb 25, 2015
Use the proper FileSystems for writing segments and caching jars. (for issue #1116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes all usages of
FileSystem.get(Configuration)(getting the default fs) with something that gets the right fs for the paths we're interacting with. Ideally that means fs.defaultFS, segmentOutputPath, and the workingPath could all be on different fses and things should still work. I haven't actually tested it yet, though…