Web console: Fix required field treatment#11228
Merged
clintropolis merged 1 commit intoapache:masterfrom May 12, 2021
Merged
Conversation
Contributor
|
@vogievetsky Do we know when this bug was introduced? I'm wondering if this is bad enough to justify backporting this to 0.21.1 release. |
Contributor
Author
|
@suneet-s the fact that the endpoint field was incorrectly marked as |
Contributor
|
@clintropolis fyi I added the milestone 0.21.1 to this bug so we can backport it before making the patch release |
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
May 12, 2021
clintropolis
added a commit
that referenced
this pull request
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the data loader flow when connecting Kinesis.
The issue is that the
Endpointfield looks like it is filled in with the default value but it also isrequiredso it requires input.The issue is fixed as a one line change in
ingestion-spec.tsxper the docs theendpointfield is not required.In addition to fixing this issue:
defaultValueis ignored whenrequiredis evaluated to trueTIMESTAMP_SPEC_FIELDSThis PR has: