Delete buildV9Directly in Kafka and Kinesis Indexing Service

[bananaaggle]

Parameter "buildV9Directly" in Kafka and Kinesis tunningConfig will be removed 0.12, but it still reserved in code. I think it is safe to remove it.

This PR has:

• been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
• added documentation for new or modified features or behaviors.
• added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
• added or updated version, license, or notice information in licenses.yaml
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
• added integration tests.
• been tested in a test Druid cluster.

[FrankChen021]

Thanks for cleaning up the code.

I see this parameter is still referenced in 'native-batch.md' but not used in the ParallelIndexTuningConfig. Could you delete it from the doc ?

[bananaaggle]

Thanks for cleaning up the code.

I see this parameter is still referenced in 'native-batch.md' but not used in the ParallelIndexTuningConfig. Could you delete it from the doc ?

I find it, but I'm not very sure delete this parameter from batch job is safe.

[FrankChen021]

I find it, but I'm not very sure delete this parameter from batch job is safe.

Actually it's not used in the code, you could check it.

[bananaaggle]

I find it, but I'm not very sure delete this parameter from batch job is safe.

Actually it's not used in the code, you could check it.

I delete this method from every where I can find it and pass all unit tests. This is a field in restful API, so I think it's safe to remove it even if some old config had it, because it will not be used and cause no exception.

[FrankChen021]

Pls check the CI.

[bananaaggle]

Pls check the CI.

Thanks! Checking now.

[bananaaggle]

Hi, @FrankChen021 , happy weekend! I run some integration tests on one EC2 like -Dgroups=batch-index, -Dgroups=query-retry, this branch passed those tests. But it failed on Travis. Is there something wrong for integration tests in Travis?

[FrankChen021]

Hi, @FrankChen021 , happy weekend! I run some integration tests on one EC2 like -Dgroups=batch-index, -Dgroups=query-retry, this branch passed those tests. But it failed on Travis. Is there something wrong for integration tests in Travis?

Might be due to flaky test. I re-triggered the failed tasks. Let's wait to see the result.

[bananaaggle]

Hi, @FrankChen021 , happy weekend! I run some integration tests on one EC2 like -Dgroups=batch-index, -Dgroups=query-retry, this branch passed those tests. But it failed on Travis. Is there something wrong for integration tests in Travis?

Might be due to flaky test. I re-triggered the failed tasks. Let's wait to see the result.

Thank you very much!

[FrankChen021]

👍

[suneet-s]

Added release notes, just in case someone is still using this even though it was deprecated for a very long time

If the release manager thinks we don't need to call this out - we can exclude this from the release notes

[clintropolis]

Added release notes, just in case someone is still using this even though it was deprecated for a very long time

This isn't necessary, it looks like this was left in place for upgrades between 0.11 and 0.12, and we just forgot to remove it. It's not hooked into anything, since all of that stuff was removed in #4420.