Skip to content

Web console: Better hotkeys and library upgrades#11365

Merged
vogievetsky merged 9 commits intoapache:masterfrom
vogievetsky:hotkeys_and_more
Jun 18, 2021
Merged

Web console: Better hotkeys and library upgrades#11365
vogievetsky merged 9 commits intoapache:masterfrom
vogievetsky:hotkeys_and_more

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

Improved the hotkeys, letting you run queries with command + enter (on mac) and ctrl + enter (on windows).

In addition this PR:

This PR has:

  • been self-reviewed.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Contributor

@jgoz jgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Really cool!

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vogievetsky
Copy link
Copy Markdown
Contributor Author

Thank you for the review, and for catching that strange interaction

@vogievetsky vogievetsky merged commit f56a5b9 into apache:master Jun 18, 2021
@vogievetsky vogievetsky deleted the hotkeys_and_more branch June 18, 2021 01:24
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants