Skip to content

Add DynamicConfigProvider for Kafka Emitter#11372

Closed
bananaaggle wants to merge 4 commits intoapache:masterfrom
bananaaggle:add_DynamicConfigProvider_for_kafka_emitter
Closed

Add DynamicConfigProvider for Kafka Emitter#11372
bananaaggle wants to merge 4 commits intoapache:masterfrom
bananaaggle:add_DynamicConfigProvider_for_kafka_emitter

Conversation

@bananaaggle
Copy link
Copy Markdown
Contributor

#10309 introduced a DynamicConfigProvider for setting Kafka properties. KafkaEmitter also needs Kafka properties. This PR use DynamicConfigProvider help to set properties in KafkaEmitter.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@bananaaggle bananaaggle force-pushed the add_DynamicConfigProvider_for_kafka_emitter branch from fd09d15 to 6d92e26 Compare August 4, 2021 09:42
@bananaaggle
Copy link
Copy Markdown
Contributor Author

Hi, @clintropolis! As I mentioned in 11362, I add extraDynamicConfigAndSetProperty to DynamicConfigProviderUtils.java to adapt to kafka properties, do you think it's properly? Thanks!

@stale
Copy link
Copy Markdown

stale Bot commented Apr 28, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Apr 28, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2023

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants