Adding more debug logs to increase visibility into StreamSupervisor notices queue size and processing time.#11415
Conversation
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
👍 seems reasonable to me
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
Looks good but please address the concern about the two logs being hard to distinguish.
BTW, it seems like a good idea to emit the queue size as a metric as well. We could do it in a follow-up PR.
@xvrl suggested the same as well :) I am working on a PR right now to add it. will raise it once its ready! |
harinirajendran
force-pushed
the
upstream_master
branch
from
0dcd77b to
48cbe8e
Compare
|
@jihoonson @xvrl Just raised https://github.com/apache/druid/pull/11417/files to add the new metric for notices queue size. |
…otices queue size and processing time.
harinirajendran
force-pushed
the
upstream_master
branch
from
48cbe8e to
3427d34
Compare
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. Thanks @harinirajendran!
|
@jihoonson @xvrl The build failure doesn't seem to be related to my changes. what do I do now? |
|
Those failed tests seem flaky. I restarted them. |
Thank u @jihoonson ! looks like they have passed now. Can we merge this PR at this point? |
|
Sure, I just merged 🙂 |
…otices queue size and processing time. (apache#11415) (cherry picked from commit 4c90c0c)
Adding more debug logs to increase visibility into StreamSupervisor notices queue size and processing time. (apache#11415)
4 participants
While I was trying to gather more info for #11414, I realized we do not have much visibility into the notices processing time inside kafka stream supervisor. Hence adding more debug logs to increase that visibility.