-
Notifications
You must be signed in to change notification settings - Fork 3.8k
option to use deep storage for storing shuffle data #11507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a40c852
option to use deep storage for storing shuffle data
pjain1 edd6b26
fix build
pjain1 561fe3e
review comments/ fix tests
pjain1 530db2c
- pusher fix
pjain1 04bdaf3
make PartitionLocation and PartitionStat interface, add unit tests
pjain1 c31f00b
remove PartialGenericSegmentMergeIngestionSpec
pjain1 fd890c9
fix test name
pjain1 c424891
java docs for PartitionStat and PartitionLocation
pjain1 47a67eb
IT for shuffle with local deep store
pjain1 e552f73
use mm
pjain1 bd0887d
IT with indexer
pjain1 a5693e1
Update index.md
pjain1 861eb94
spelling
pjain1 eff5558
add UNNEST to spellings
pjain1 6646f22
fix tests, local data manager now reads the version
pjain1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
...va/org/apache/druid/indexing/common/task/batch/parallel/DeepStoragePartitionLocation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.druid.indexing.common.task.batch.parallel; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonIgnore; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import org.apache.druid.timeline.partition.BuildingShardSpec; | ||
| import org.joda.time.Interval; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * This class represents the intermediary deep storage location where the partition of {@code interval} and {@code shardSpec} | ||
| * is stored. | ||
| */ | ||
| public class DeepStoragePartitionLocation implements PartitionLocation | ||
| { | ||
| private final String subTaskId; | ||
| private final Interval interval; | ||
| private final BuildingShardSpec shardSpec; | ||
| private final Map<String, Object> loadSpec; | ||
|
|
||
| @JsonCreator | ||
| public DeepStoragePartitionLocation( | ||
|
pjain1 marked this conversation as resolved.
|
||
| @JsonProperty("subTaskId") String subTaskId, | ||
| @JsonProperty("interval") Interval interval, | ||
| @JsonProperty("shardSpec") BuildingShardSpec shardSpec, | ||
| @JsonProperty("loadSpec") Map<String, Object> loadSpec | ||
| ) | ||
| { | ||
| this.subTaskId = subTaskId; | ||
| this.interval = interval; | ||
| this.shardSpec = shardSpec; | ||
| this.loadSpec = loadSpec; | ||
| } | ||
|
|
||
| @JsonIgnore | ||
| @Override | ||
| public int getBucketId() | ||
| { | ||
| return shardSpec.getBucketId(); | ||
| } | ||
|
|
||
| @JsonProperty | ||
| @Override | ||
| public Interval getInterval() | ||
| { | ||
| return interval; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| @Override | ||
| public BuildingShardSpec getShardSpec() | ||
| { | ||
| return shardSpec; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| @Override | ||
| public String getSubTaskId() | ||
| { | ||
| return subTaskId; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public Map<String, Object> getLoadSpec() | ||
| { | ||
| return loadSpec; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) | ||
| { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| DeepStoragePartitionLocation that = (DeepStoragePartitionLocation) o; | ||
| return subTaskId.equals(that.subTaskId) | ||
| && interval.equals(that.interval) | ||
| && shardSpec.equals(that.shardSpec) | ||
| && loadSpec.equals(that.loadSpec); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() | ||
| { | ||
| return Objects.hash(subTaskId, interval, shardSpec, loadSpec); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() | ||
| { | ||
| return "DeepStoragePartitionLocation{" + | ||
| "subTaskId='" + subTaskId + '\'' + | ||
| ", interval=" + interval + | ||
| ", shardSpec=" + shardSpec + | ||
| ", loadSpec=" + loadSpec + | ||
| '}'; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.