Upgrade ORC to 1.6.9#11518
Conversation
|
@dongjoon-hyun - Thanks for the change - I wanted to ask that in the |
|
Hi, @rohangarg . Thank you for review. Yes. AFAIK, the
|
|
Oh, I double-checked it. It seems that the exclusion rules of |
|
@rohangarg . Are you sure about your comment? Druid analyze check seems to enforce the declaration.
I'll revert the last commit because this PR already passed before the last commit. |
This reverts commit 3bb219b.
|
@dongjoon-hyun : Yes, you are right. Apologies, I missed that dependency analysis in druid fails compilation if we're not declaring any directly used dependency (the default maven behavior gives a warning). Maybe that was the original reason to keep it explicit :) I had missed the You updated change LGTM - thanks for the tryout and changes! |
|
Could you review this PR when you have a time, @jihoonson ?
|
|
:) I also learned it at this time. Thank you for you reviews and helps, @rohangarg . |
|
@dongjoon-hyun sure, I will have a look soon. |
|
The one failure looks irrelevant to this one because the last commit (2feb9a3) is identical to the this commit (9698b7d) which passed all tested. |
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. Thanks @dongjoon-hyun!
|
Thank you so much, @jihoonson ! |
Description
This PR aims to upgrade Apache ORC from 1.5.10 to 1.6.9 and
licenses.yamlcorrespondingly to bring the latest bug fixes and updates.Apache ORC 1.5.10 is too old and the following versions are available. Apache ORC community highly recommends to use 1.6.9.
This PR has: