Skip to content

Add vavr dependency to benchmarks pom.xml#11523

Closed
jon-wei wants to merge 1 commit intoapache:masterfrom
jon-wei:vavr_benchmark_dep
Closed

Add vavr dependency to benchmarks pom.xml#11523
jon-wei wants to merge 1 commit intoapache:masterfrom
jon-wei:vavr_benchmark_dep

Conversation

@jon-wei
Copy link
Copy Markdown
Contributor

@jon-wei jon-wei commented Jul 30, 2021

This PR adds an undeclared io.vavr dependency to the benchmarks pom.xml, which was referenced in the changes from #11257

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Jul 30, 2021

Closing in favor of #11522

@jon-wei jon-wei closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant