Web console: Improve the lookup view UX#11620
Merged
clintropolis merged 8 commits intoapache:masterfrom Aug 30, 2021
Merged
Conversation
| if (!uri) return; | ||
| const m = /^(\w+):/.exec(uri); | ||
| if (!m) return `URI is invalid, must start with 'file:', 'hdfs:', or 's3:'`; | ||
| if (!oneOf(m[1], 'file', 'hdfs', 's3')) { |
Member
There was a problem hiding this comment.
since #11026 google cloud lookups are also supported
Contributor
Author
There was a problem hiding this comment.
thanks for the note! Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to make the lookup view more friendly. Here is the before and after screenshots of the lookup view:
Before:
After:
The notable changes are:
Poll periodandSummaryare added as additional info columnsLookup namenowPoll periodrequired for extraction lookups as not setting it is guaranteed to be a time bomb for when a new server is spun up and the lookups go out of sync.MV_*functions before)New inline error validation:
This PR has: