updates Kafka and Kinesis to use . Fixes some typos and other style i…#11624
Merged
jihoonson merged 11 commits intoapache:masterfrom Aug 26, 2021
Merged
updates Kafka and Kinesis to use . Fixes some typos and other style i…#11624jihoonson merged 11 commits intoapache:masterfrom
jihoonson merged 11 commits intoapache:masterfrom
Conversation
jihoonson
reviewed
Aug 25, 2021
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
@techdocsmith thanks for fixing the supervisor spec examples!
| - You need Druid to consume older versions of Kafka. | ||
|
|
||
| ## Tutorial | ||
| Make sure offsets are sequential, since there is no offset gap check in Druid anymore. |
Contributor
There was a problem hiding this comment.
I think this applies only in one of the above cases (non-transactional topic or older kafka versions), so it could be better to make it more obvious.
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Co-authored-by: Jihoon Son <jihoonson@apache.org>
jihoonson
approved these changes
Aug 26, 2021
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. Thanks @techdocsmith!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Kafka and Kinesis to use
specformat according to #8810.Fixes some grammar, typos, and other style issues for Kafka.
This PR has: