Skip to content

Fix broken build due to https://github.com/apache/druid/pull/11090#11727

Merged
maytasm merged 1 commit intoapache:masterfrom
maytasm:fix_build_stat
Sep 21, 2021
Merged

Fix broken build due to https://github.com/apache/druid/pull/11090#11727
maytasm merged 1 commit intoapache:masterfrom
maytasm:fix_build_stat

Conversation

@maytasm
Copy link
Copy Markdown
Contributor

@maytasm maytasm commented Sep 21, 2021

Fix broken build due to #11090

Description

This change in #11090 that was merged a few hours ago is causing build to fail. This is because the change #11688 that went in a few days ago use the IngestionStatsAndErrorsTaskReportData constructor which was changed in #11090. Note that when #11090 got merged in, the Travis green check in that PR was from 25 days ago.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@maytasm maytasm requested review from capistrant, clintropolis, jihoonson and jon-wei and removed request for clintropolis September 21, 2021 08:03
@cryptoe
Copy link
Copy Markdown
Contributor

cryptoe commented Sep 21, 2021

LGTM

@maytasm maytasm merged commit 3c487ff into apache:master Sep 21, 2021
@maytasm
Copy link
Copy Markdown
Contributor Author

maytasm commented Sep 21, 2021

Overriding Travis to unblock other PRs. Successfully build and compile locally

@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants