Add killAndRestart for container for integration tests#11754
Merged
jihoonson merged 1 commit intoapache:masterfrom Sep 30, 2021
Merged
Add killAndRestart for container for integration tests#11754jihoonson merged 1 commit intoapache:masterfrom
jihoonson merged 1 commit intoapache:masterfrom
Conversation
clintropolis
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#9576 added utility functions for integration tests including restarting docker containers. This PR adds a new utility method to kill a container with
SIGKILLand restart the container. This could be useful for testing certain edge cases where some node is forced to exit without graceful shutdown. I made this method public along with others since the current way providing utility methods for each node doesn't seem scalable. This PR also fixes a bug inSqlQueryWithResultsthatJsonPropertyannotations are missing for parameters.This PR has: