Skip to content

add prometheus-emitter to distribution #11812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clintropolis merged 2 commits into from
Oct 26, 2021
Merged

add prometheus-emitter to distribution #11812

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff81a92
add `prometheus-emitter` to distribution
dungdm93 Oct 19, 2021
84a20c9
add `druid-momentsketch` to distribution
dungdm93 Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions distribution/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:statsd-emitter</argument>
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:prometheus-emitter</argument>
Copy link
Copy Markdown
Member

@clintropolis clintropolis Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

I did a quick check and it looks like we are also missing druid-momentsketch, would you mind adding it too?

druid-testing-tools is also not in any profile, but I'm not sure it actually makes sense to include anyway so we should ignore it for now, because its primary purpose is to aid in writing integration tests since it includes mechanisms to control query execution time.

Copy link
Copy Markdown
Contributor Author

@dungdm93 dungdm93 Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @clintropolis, druid-momentsketch is added.

<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:druid-thrift-extensions</argument>
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:druid-time-min-max</argument>
Expand All @@ -425,6 +427,8 @@
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:druid-moving-average-query</argument>
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:druid-momentsketch</argument>
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:druid-tdigestsketch</argument>
<argument>-c</argument>
<argument>org.apache.druid.extensions.contrib:gce-extensions</argument>
Expand Down