Add Finalization option to RowSignature.addAggregators.#11882
Merged
gianm merged 3 commits intoapache:masterfrom Nov 10, 2021
Merged
Add Finalization option to RowSignature.addAggregators.#11882gianm merged 3 commits intoapache:masterfrom
gianm merged 3 commits intoapache:masterfrom
Conversation
This make type signatures more useful when the caller knows whether it will be reading aggregation results in their finalized or intermediate types.
clintropolis
approved these changes
Nov 10, 2021
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
🤘 though, still a lot of work to do to get this wired through
gianm
added a commit
to gianm/druid
that referenced
this pull request
Nov 11, 2021
PR apache#11882 introduced a type comparison using ==, but while it was in flight, another PR apache#11713 changed the type enum to a class. So the comparison should properly be done with "equals".
clintropolis
pushed a commit
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make type signatures more useful when the caller knows whether it will
be reading aggregation results in their finalized or intermediate types.