Skip to content

Docs: Splits Kafka topic. Adds detailed example for kafka inputFormat#11912

Merged
techdocsmith merged 7 commits intoapache:masterfrom
techdocsmith:kafka-inputtype
Nov 12, 2021
Merged

Docs: Splits Kafka topic. Adds detailed example for kafka inputFormat#11912
techdocsmith merged 7 commits intoapache:masterfrom
techdocsmith:kafka-inputtype

Conversation

@techdocsmith
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith commented Nov 11, 2021

This PR breaks down the Kafka topic into three functional areas:
Apache Kafka ingestion: Overview, instructions, and examples
Kafka supervisor spec reference: Details for all the fields in the supervisor spec
Kafka supervisor operations reference: Details on how to keep the supervisor healthy and running

It adds an example of the kafka input type.

cc: @lokesh-lingarajan

This PR has:

  • been self-reviewed.
  • [x ] been tested in a test Druid cluster.

Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Copy link
Copy Markdown

@sthetland sthetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how it's broken out and how the main kafka-ingestion page looks more procedural. A big improvement. Some comments and suggestions below.

Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Copy link
Copy Markdown
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions.

Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-supervisor-reference.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md
Comment thread docs/development/extensions-core/kafka-ingestion.md
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
Comment thread docs/development/extensions-core/kafka-ingestion.md Outdated
techdocsmith and others added 4 commits November 11, 2021 15:35
accept suggestions from review

Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
accept suggestions

Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
Copy link
Copy Markdown

@sthetland sthetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@techdocsmith techdocsmith merged commit 33a5cda into apache:master Nov 12, 2021
@techdocsmith techdocsmith deleted the kafka-inputtype branch November 12, 2021 21:02
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants