Add new metric that quantifies how long batch ingest jobs waited for segment availability and whether or not that wait was successful#12002
Merged
capistrant merged 5 commits intoapache:masterfrom Dec 10, 2021
Conversation
kfaraz
approved these changes
Dec 6, 2021
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for adding this @capistrant, seems like a useful metric!
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supplement to #10676 and #11090 .... Adds a new metric that is emitted as a batch task completes it's wait for segment availability. The metric value is the milliseconds waited. The new dimension is a boolean that states if the wait was successful or not. The value of this metric is that it tells operators how long the coordinator is taking to distribute segments to historicals after indexing completes. As an operator myself, I track this value to make sure our coordinator performance is up to the expectation of users when it comes to how long after indexing completes their data is available.
Key changed/added classes in this PR
AbstractBatchIndexTaskIndexTaskTestThis PR has: