Merged
Conversation
suneet-s
approved these changes
Dec 13, 2021
Contributor
suneet-s
left a comment
suneet-s
left a comment
There was a problem hiding this comment.
+1 after license check job passes
jihoonson
approved these changes
Dec 13, 2021
clintropolis
approved these changes
Dec 14, 2021
|
"(We don't ship with any JNDI features enabled.)" this operation should be OK? will not affect the druid cluster functions? |
Contributor
Author
|
@hzluyang removing the JndiLookup class from the log4j-core jar is OK. We tested doing that, and Druid still works fine afterwards. |
|
Which version will include that 2.16 ? next 0.22.2 ? |
|
I'm waiting for 0.22.2 too ;) |
nikhil-ddu
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Dec 17, 2021
* Update to log4j 2.16.0. * Update licenses.yaml
nikhil-ddu
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Dec 17, 2021
* Update to log4j 2.16.0. * Update licenses.yaml
debasatwa29
pushed a commit
to debasatwa29/druid
that referenced
this pull request
Jun 2, 2022
Summary: Upgrade log4j to 2.16 Pulls upstream: apache#12061 According to the description of the upstream PR, we should be safe with 2.15 but it's good to upgrade. Reviewers: O1139 Druid, yyang Reviewed By: O1139 Druid, yyang Subscribers: jenkins, shawncao, #realtime-analytics Differential Revision: https://phabricator.pinadmin.com/D824772
ruchinkabra
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Jun 13, 2022
* Update to log4j 2.16.0. * Update licenses.yaml
anishanagarajan
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Sep 23, 2022
* Update to log4j 2.16.0. * Update licenses.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log4j 2.16.0 is further hardened and makes it impossible for users to stumble into a configuration that is vulnerable to the CVE-2021-44228 issue. I don't think this is a fire-drill update, because Druid 0.22.1+ with Log4j 2.15.0 is not vulnerable in its default configuration. (We don't ship with any JNDI features enabled.) But the additional hardening would be beneficial to our users.
See announcement at: https://lists.apache.org/thread/t72msv9cpxw9q5zw8rfkhx52v24z57f1