Skip to content

Remove "offheap" IncrementalIndex from Benchmarks #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liran-funaro wants to merge 2 commits into from
Closed

Remove "offheap" IncrementalIndex from Benchmarks #12121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b98148
Remove "offheap" IncrementalIndex from Benchmarks
liran-funaro Jan 5, 2022
e74350d
Merge remote-tracking branch 'upstream/master' into remove-offheap-be…
liran-funaro Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmarks/src/test/java/org/apache/druid/benchmark/FilteredAggregatorBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public void setup()
@State(Scope.Benchmark)
public static class IncrementalIndexState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down Expand Up @@ -234,7 +234,7 @@ public void tearDown()
@State(Scope.Benchmark)
public static class IncrementalIndexIngestState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/IncrementalIndexRowTypeBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public class IncrementalIndexRowTypeBenchmark
@Param({"250000"})
private int rowsPerSegment;

@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

private AppendableIndexSpec appendableIndexSpec;
Expand Down
2 changes: 1 addition & 1 deletion ...arks/src/test/java/org/apache/druid/benchmark/indexing/IncrementalIndexReadBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public class IncrementalIndexReadBenchmark
@Param({"true", "false"})
private boolean rollup;

@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

private static final Logger log = new Logger(IncrementalIndexReadBenchmark.class);
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IndexIngestionBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public class IndexIngestionBenchmark
@Param({"none", "moderate", "high"})
private String rollupOpportunity;

@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

private static final Logger log = new Logger(IndexIngestionBenchmark.class);
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IndexPersistBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public class IndexPersistBenchmark
@Param({"none", "moderate", "high"})
private String rollupOpportunity;

@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

private AppendableIndexSpec appendableIndexSpec;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/query/GroupByBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ public String getFormatString()
@State(Scope.Benchmark)
public static class IncrementalIndexState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/query/ScanBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ public void setup()
@State(Scope.Benchmark)
public static class IncrementalIndexState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/query/SearchBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ public void setup()
@State(Scope.Benchmark)
public static class IncrementalIndexState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/query/TimeseriesBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public void setup()
@State(Scope.Benchmark)
public static class IncrementalIndexState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/query/TopNBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public void setup()
@State(Scope.Benchmark)
public static class IncrementalIndexState
{
@Param({"onheap", "offheap"})
@Param({"onheap"})
private String indexType;

IncrementalIndex incIndex;
Expand Down