Update PostAggregator to be backwards compat#12138
Merged
clintropolis merged 1 commit intoapache:masterfrom Jan 11, 2022
Merged
Update PostAggregator to be backwards compat#12138clintropolis merged 1 commit intoapache:masterfrom
clintropolis merged 1 commit intoapache:masterfrom
Conversation
imply-cheddar
force-pushed
the
post-agg-compact-22-1
branch
from
26e6e7a to
a96fbd9
Compare
clintropolis
approved these changes
Jan 11, 2022
This change mimics what was done in PR 11917 to fix the incompatibilities produced by 11713. 11917 fixed it with AggregatorFactory by creating default methods to allow for extensions built against old jars to still work. This does the same for PostAggregator
imply-cheddar
force-pushed
the
post-agg-compact-22-1
branch
from
a96fbd9 to
a92fdd2
Compare
Member
|
ignoring coverage check since it is a backwards compat thing |
sachinsagare
pushed a commit
to pinterest/druid
that referenced
this pull request
Oct 28, 2022
This change mimics what was done in PR apache#11917 to fix the incompatibilities produced by apache#11713. apache#11917 fixed it with AggregatorFactory by creating default methods to allow for extensions built against old jars to still work. This does the same for PostAggregator (cherry picked from commit eb0bae4)
sachinsagare
pushed a commit
to sachinsagare/druid
that referenced
this pull request
Nov 2, 2022
This change mimics what was done in PR apache#11917 to fix the incompatibilities produced by apache#11713. apache#11917 fixed it with AggregatorFactory by creating default methods to allow for extensions built against old jars to still work. This does the same for PostAggregator (cherry picked from commit eb0bae4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change mimics what was done in PR #11917 to
fix the incompatibilities produced by #11713. #11917
fixed it with AggregatorFactory by creating default
methods to allow for extensions built against old
jars to still work. This does the same for PostAggregator
This PR has: