Skip to content

Fix ci#12304

Merged
samarthjain merged 3 commits intoapache:masterfrom
samarthjain:fixci
Mar 4, 2022
Merged

Fix ci#12304
samarthjain merged 3 commits intoapache:masterfrom
samarthjain:fixci

Conversation

@samarthjain
Copy link
Copy Markdown
Contributor

Fix CI broken after 3619395

@clintropolis
Copy link
Copy Markdown
Member

i think we can merge after the forbidden api check passes

@samarthjain
Copy link
Copy Markdown
Contributor Author

Not sure why the build is still complaining about String.format. I am going to retry the build.

@samarthjain samarthjain closed this Mar 4, 2022
@samarthjain samarthjain reopened this Mar 4, 2022
@samarthjain
Copy link
Copy Markdown
Contributor Author

I am not sure why the LGTM build is still failing. Should I go ahead and merge this PR, @clintropolis, @jihoonson ? The build is failing right at the line that this PR is fixing.

@samarthjain
Copy link
Copy Markdown
Contributor Author

i am going to go ahead and merge this PR.

@samarthjain samarthjain merged commit 58d05d7 into apache:master Mar 4, 2022
@samarthjain samarthjain deleted the fixci branch March 4, 2022 07:05
@jihoonson
Copy link
Copy Markdown
Contributor

@samarthjain thanks for merging this PR. I think that LGTM has a step that runs a build against master before applying your change. LGTM seems to have failed in that step, which can't be passed without your change. It makes sense to me to ignore it this time. The forbidden API checks passed after this change is merged in https://app.travis-ci.com/github/apache/druid/builds/247394888.

@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants