improve FileWriteOutBytes.readFully#12323
Merged
clintropolis merged 2 commits intoapache:masterfrom Mar 9, 2022
Merged
Conversation
cheddar
approved these changes
Mar 9, 2022
gianm
approved these changes
Mar 9, 2022
TSFenwick
pushed a commit
to TSFenwick/druid
that referenced
this pull request
Apr 11, 2022
* improve FileWriteOutBytes.readFully * no need to flush if out of bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the performance of
FileWriteOutBytes.readFullyby using the tracked byte size added in #9722, instead of calling the channel size() method, which ends up in a native syscall to check the size of the file on disk. ThisreadFullymethod is used byGenericIndexedWriter.getwhich is currently only used when merging spatial indexes, but would be an improvement for anything looking to read stuff out of the channel.This PR has: