Skip to content

Metrics for shenandoah#12369

Merged
gianm merged 1 commit intoapache:masterfrom
didip:shenandoah-jvm-metrics
Apr 22, 2022
Merged

Metrics for shenandoah#12369
gianm merged 1 commit intoapache:masterfrom
didip:shenandoah-jvm-metrics

Conversation

@didip
Copy link
Copy Markdown
Contributor

@didip didip commented Mar 28, 2022

Based on this source code:

https://github.com/openjdk/jdk/blob/554caf33a01ac9ca2e3e9170557e8348750f3971/src/hotspot/share/gc/shenandoah/shenandoahMonitoringSupport.cpp#L65

Partially fixes #6424 by generating metrics for Shenandoah. Too bad ZGC does not have similar MonitoringSupport.cpp file.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@xvrl
Copy link
Copy Markdown
Member

xvrl commented Mar 31, 2022

@didip can you confirm which JVM versions this works with? Have you only tested on Java 11 or does this also work on Java 15?

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Apr 19, 2022

@didip can you confirm which JVM versions this works with? Have you only tested on Java 11 or does this also work on Java 15?

I just checked and it looks like the names "Shenandoah partial" and "Shenandoah full" are used on both Java 11 and Java 15.

@didip
Copy link
Copy Markdown
Contributor Author

didip commented Apr 21, 2022

@gianm yes, correct. Sorry for the late response, I am still on paternity leave.

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Apr 22, 2022

@gianm yes, correct. Sorry for the late response, I am still on paternity leave.

No problem; and, congratulations 🙂

The only legit failure for this patch is test coverage. I'm planning on adding additional tests for JvmMonitor in #12469, so I'll merge this patch now and do all the new tests over there.

@gianm gianm merged commit 2473de2 into apache:master Apr 22, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
@didip didip deleted the shenandoah-jvm-metrics branch June 22, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support new Java GC algorithms (Shenandoah and ZGC) in JvmMonitor

5 participants