Conversation
|
@didip can you confirm which JVM versions this works with? Have you only tested on Java 11 or does this also work on Java 15? |
I just checked and it looks like the names "Shenandoah partial" and "Shenandoah full" are used on both Java 11 and Java 15. |
|
@gianm yes, correct. Sorry for the late response, I am still on paternity leave. |
No problem; and, congratulations 🙂 The only legit failure for this patch is test coverage. I'm planning on adding additional tests for JvmMonitor in #12469, so I'll merge this patch now and do all the new tests over there. |
Based on this source code:
https://github.com/openjdk/jdk/blob/554caf33a01ac9ca2e3e9170557e8348750f3971/src/hotspot/share/gc/shenandoah/shenandoahMonitoringSupport.cpp#L65
Partially fixes #6424 by generating metrics for Shenandoah. Too bad ZGC does not have similar MonitoringSupport.cpp file.
This PR has: