Skip to content

Package kinesis client jar within the extension#12370

Merged
abhishekagarwal87 merged 5 commits intoapache:masterfrom
AmatyaAvadhanula:feature-package_kinesis_client
Apr 4, 2022
Merged

Package kinesis client jar within the extension#12370
abhishekagarwal87 merged 5 commits intoapache:masterfrom
AmatyaAvadhanula:feature-package_kinesis_client

Conversation

@AmatyaAvadhanula
Copy link
Copy Markdown
Contributor

@AmatyaAvadhanula AmatyaAvadhanula commented Mar 28, 2022

Description

amazon-kinesis-client was not covered undered the apache license and required separate insertion in the kinesis extension.
This can now be avoided since it is covered, and including it within druid helps prevent incompatibilities.

Allows enabling of deaggregation out of the box by packaging amazon-kinesis-client (1.14.4) with druid for kinesis ingestion.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@FrankChen021
Copy link
Copy Markdown
Member

license file should be updated.

Error: found 3 missing licenses. These licenses are reported, but missing in the registry
druid_module: kinesis-indexing-service, groupId: com.amazonaws, artifactId: aws-java-sdk-dynamodb, version: 1.12.3, license: Apache License version 2.0
druid_module: kinesis-indexing-service, groupId: com.amazonaws, artifactId: aws-java-sdk-cloudwatch, version: 1.12.3, license: Apache License version 2.0
druid_module: kinesis-indexing-service, groupId: com.amazonaws, artifactId: amazon-kinesis-client, version: 1.14.4, license: Apache License version 2.0

@abhishekagarwal87 abhishekagarwal87 merged commit 067254b into apache:master Apr 4, 2022
TSFenwick pushed a commit to TSFenwick/druid that referenced this pull request Apr 11, 2022
amazon-kinesis-client was not covered undered the apache license and required separate insertion in the kinesis extension.
This can now be avoided since it is covered, and including it within druid helps prevent incompatibilities.

Allows enabling of deaggregation out of the box by packaging amazon-kinesis-client (1.14.4) with druid for kinesis ingestion.
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
@gianm gianm mentioned this pull request Nov 29, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants