Skip to content

Blueprint 4#12391

Merged
vogievetsky merged 5 commits intoapache:masterfrom
jgoz:blueprint-4
Apr 4, 2022
Merged

Blueprint 4#12391
vogievetsky merged 5 commits intoapache:masterfrom
jgoz:blueprint-4

Conversation

@jgoz
Copy link
Copy Markdown
Contributor

@jgoz jgoz commented Apr 1, 2022

Description

Upgrades the Blueprint dependencies in the web-console to v4:

The process for upgrading was recorded and documented here:
https://www.youtube.com/watch?v=Ew8BgdCfMDg

After the recording, I also did the following:

  • Update licenses
  • Update unit test snapshots
  • Update selectors in e2e tests to use .bp4

Note that a webpack alias was needed to allow color variables to be overwritten. The reasoning is documented in webpack.config.js.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vogievetsky vogievetsky merged commit 9068054 into apache:master Apr 4, 2022
TSFenwick pushed a commit to TSFenwick/druid that referenced this pull request Apr 11, 2022
* Update blueprint dependencies & LICENSES

* Switch to bp4 namespace; use bp-ns variable in overrides

* Add webpack alias for colors.scss

* Snapshots

* Update selectors in e2e tests
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants