Skip to content

Updating an error msg#12450

Merged
suneet-s merged 2 commits intoapache:masterfrom
somu-imply:planningErrMsg
Apr 20, 2022
Merged

Updating an error msg#12450
suneet-s merged 2 commits intoapache:masterfrom
somu-imply:planningErrMsg

Conversation

@somu-imply
Copy link
Copy Markdown
Contributor

@somu-imply somu-imply commented Apr 18, 2022

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suneet-s
Copy link
Copy Markdown
Contributor

Follow up to #12418 (comment)

Copy link
Copy Markdown
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will merge after CI passes. I re-triggered what looked like a flaky test.

Thanks @somu-imply !

@suneet-s suneet-s merged commit 2db0287 into apache:master Apr 20, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants