Skip to content

Improve build performance of modules #12486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrankChen021 merged 4 commits into from
May 1, 2022
Merged

Improve build performance of modules #12486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f81b241
improve build performance of modules
MC-JY Apr 27, 2022
9ebf707
improve build performance of modules
MC-JY Apr 27, 2022
c3ae408
Update pom.xml
MC-JY Apr 28, 2022
ca0851f
improve build performance of modules
MC-JY Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions extensions-core/druid-basic-security/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,6 @@
<version>${project.parent.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.druid</groupId>
<artifactId>druid-services</artifactId>
<version>${project.parent.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.druid</groupId>
<artifactId>druid-server</artifactId>
Expand Down
6 changes: 0 additions & 6 deletions server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@
<version>${project.parent.version}</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.druid</groupId>
<artifactId>druid-console</artifactId>
<version>${project.parent.version}</version>
<scope>runtime</scope>
</dependency>
Copy link
Copy Markdown
Contributor

@vogievetsky vogievetsky May 3, 2022 •
edited by clintropolis
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up: I am reverting this change here 592ddd4

Removing the druid-console dependency makes the web console no longer be part of Druid...

image

The e2e tests do not run unless there are JS changes which is how this PR passed CI. I was struggling to figure out why my console PR (#12489) was failing to even start the e2e tests when it turned out that the console was just gone...

image

So I am adding this dependency back. Fun fact, my PR (linked above) will actually improve the console build speed a little bit by removing the stylus dependency but obviously not as much as not building the console all together.

Copy link
Copy Markdown
Member

@clintropolis clintropolis May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on ^, I think maybe we should consider running web e2e tests on java changes, instead of just web-console changes.

Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running web e2e tests on java changes may be too burden. IMO, we can add one test case to check if localhost:888/unified-console.html returns HTTP 200.

Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vogievetsky Do you mean the druid-console.jar is missing in the distribution package after deleting the depedency declaration from server/pom.xml ?

Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final distribution package is packaged by maven-assembly-plugin. I think we can make some modifications to the assembly file under distribution/src/assembly/assembly.xml to include the druid-console module in the final package. If it's viable, we don't need to include druid-console module in the druid-server module which really looks a little bit strange.

<dependency>
<groupId>org.apache.druid</groupId>
<artifactId>druid-core</artifactId>
Expand Down