Skip to content

Web console: fix go to segments not working #12541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clintropolis merged 2 commits into from
May 19, 2022
Merged

Web console: fix go to segments not working #12541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de11867
use correct filter syntax
vogievetsky May 19, 2022
afecb55
fix tests
vogievetsky May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web-console/src/views/datasources-view/datasources-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ ORDER BY 1`;

const datasourceFilter: Filter[] = [];
if (props.initDatasource) {
datasourceFilter.push({ id: 'datasource', value: `"${props.initDatasource}"` });
datasourceFilter.push({ id: 'datasource', value: `=${props.initDatasource}` });
}

this.state = {
Expand Down
6 changes: 3 additions & 3 deletions web-console/src/views/ingestion-view/__snapshots__/ingestion-view.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ exports[`IngestionView matches snapshot 1`] = `
Array [
Object {
"id": "datasource",
"value": "datasource",
"value": "=datasource",
},
]
}
Expand Down Expand Up @@ -536,11 +536,11 @@ exports[`IngestionView matches snapshot 1`] = `
Array [
Object {
"id": "group_id",
"value": "test",
"value": "=test",
},
Object {
"id": "datasource",
"value": "datasource",
"value": "=datasource",
},
]
}
Expand Down
7 changes: 4 additions & 3 deletions web-console/src/views/ingestion-view/ingestion-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,12 @@ ORDER BY "rank" DESC, "created_time" DESC`;
super(props, context);

const taskFilter: Filter[] = [];
if (props.taskGroupId) taskFilter.push({ id: 'group_id', value: props.taskGroupId });
if (props.datasourceId) taskFilter.push({ id: 'datasource', value: props.datasourceId });
if (props.taskGroupId) taskFilter.push({ id: 'group_id', value: `=${props.taskGroupId}` });
if (props.datasourceId) taskFilter.push({ id: 'datasource', value: `=${props.datasourceId}` });

const supervisorFilter: Filter[] = [];
if (props.datasourceId) supervisorFilter.push({ id: 'datasource', value: props.datasourceId });
if (props.datasourceId)
supervisorFilter.push({ id: 'datasource', value: `=${props.datasourceId}` });

this.state = {
supervisorsState: QueryState.INIT,
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/views/segments-view/__snapshots__/segments-view.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ exports[`SegmentsView matches snapshot 1`] = `
Array [
Object {
"id": "datasource",
"value": "\\"test\\"",
"value": "=test",
},
]
}
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/views/segments-view/segments-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ END AS "time_span"`,
super(props, context);

const segmentFilter: Filter[] = [];
if (props.datasource) segmentFilter.push({ id: 'datasource', value: `"${props.datasource}"` });
if (props.datasource) segmentFilter.push({ id: 'datasource', value: `=${props.datasource}` });
if (props.onlyUnavailable) segmentFilter.push({ id: 'is_available', value: 'false' });

this.state = {
Expand Down