Skip to content

Fix thread-unsafe emitter usage in SeekableStreamSupervisorStateTest. #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Jun 23, 2022
Merged

Fix thread-unsafe emitter usage in SeekableStreamSupervisorStateTest. #12658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...rg/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.concurrent.GuardedBy;
import org.apache.druid.data.input.impl.ByteEntity;
import org.apache.druid.data.input.impl.DimensionSchema;
import org.apache.druid.data.input.impl.DimensionsSpec;
Expand Down Expand Up @@ -1371,17 +1372,22 @@ protected void scheduleReporting(ScheduledExecutorService reportingExec)

private static class TestEmitter extends NoopServiceEmitter
{
@GuardedBy("events")
private final List<Event> events = new ArrayList<>();

@Override
public void emit(Event event)
{
events.add(event);
synchronized (events) {
events.add(event);
}
}

public List<Event> getEvents()
{
return events;
synchronized (events) {
return ImmutableList.copyOf(events);
}
}
}
}