Disable autokill of segments by default.#12693
Merged
gianm merged 1 commit intoapache:masterfrom Jun 24, 2022
Merged
Conversation
Also add clarifying commentary to the documentation about how durationToRetain works.
8 tasks
clintropolis
approved these changes
Jun 23, 2022
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
sgtm 👍
Should we call out in the 0.23 release notes in a stronger manner that this default has been changed, the implications, and that we are switching it back for the next release?
Contributor
Author
IMO, yes, it would be good for the mention in the 0.23.0 release notes to be more prominent. It's tucked away in the "Coordinator/Overlord" section now, but it's really a bigger change than that. It affects the whole system. |
capistrant
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #12187 the default was changed to
druid.coordinator.kill.on = true. However, I think this is too risky of a default without the logic in #12526. Currently the main safeguard against accidental permanent deletion isdurationToRetain, which is based on the segment interval, not the time the segment was marked unused. This means older segments can be eligible for autokilling immediately after being marked unused. This can happen by mistake: someone might activate the "mark unused" functionality (via API or web console) for the wrong datasource, or the wrong interval. Then autokilling can turn that small mistake into a big mistake.So, I think we should change the default back to
falseand revisit once the logic in #12526 is implemented. This patch does that, as well as updates the docs to be more clear about how the behavior works, so people can understand it prior to turning autokilling on.