Web console: reindex flow should take order from Druid#12790
Merged
vogievetsky merged 1 commit intoapache:masterfrom Jul 15, 2022
Merged
Web console: reindex flow should take order from Druid#12790vogievetsky merged 1 commit intoapache:masterfrom
vogievetsky merged 1 commit intoapache:masterfrom
Conversation
vogievetsky
changed the title
clintropolis
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #12754 we can now use the column order returned by a
scanquery to determine the column order for reindexing data. This means we no longer need to rely on the (technically undefined) order of keys in the JSON object (this PR removes code that uses the ordering fromObject.keys/Object.values)