fix expression plan type inference to correctly handle complex types#12857
Merged
clintropolis merged 1 commit intoapache:masterfrom Aug 4, 2022
Merged
Conversation
vogievetsky
approved these changes
Aug 4, 2022
gianm
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
ExpressionPlan.inferColumnCapabilities, which is used by nativeExpressionVirtualColumnto infer the output type from the input row signature, and can play a role in determining the output row signature of a query to correctly handleCOMPLEXtyped expressions (added in #11853). This bug could cause incorrect behavior due to this method making defaultSTRINGtyped capabilities, causing incorrect selectors to be chosen, which for json columns whose in process values are things like javaMapto effectively be callingtoStringon everything, which for something likeJSON_OBJECT(KEY 'a' VALUE 'A', KEY 'b' VALUE 1)would end up with the values as strings appearing like'{a=A, b=1}'instead of actual JSON{"a":"A", "b":1}.The fix is just to add a short circuit for
COMPLEXtypes so that the default string capabilities are not used.This PR has: