Auto-reload TLS certs for druid endpoints#12933
Auto-reload TLS certs for druid endpoints#12933FrankChen021 merged 8 commits intoapache:masterfrom santosh-d3vpl3x:master
Conversation
Co-authored-by: zemin-piao <pzm6391@gmail.com>
|
The failure is unrelated to the PR. |
|
@FrankChen021 would you be interested in reviewing this PR? |
|
|
||
| sslConnector.setPort(0); | ||
| server.setConnectors(new Connector[]{sslConnector}); | ||
| KeyStoreScanner keyStoreScanner = new KeyStoreScanner(sslContextFactory); |
There was a problem hiding this comment.
This wouldn't detect keystore changes if the keystore path was a soft link, would it?
There was a problem hiding this comment.
Good question, https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/tests/test-integration/src/test/java/org/eclipse/jetty/test/KeyStoreScannerTest.java#L182-L206 leads me to believe that it has that ability.
a2l007
left a comment
a2l007
left a comment
There was a problem hiding this comment.
@santosh-d3vpl3x Thank you for your contribution!
Co-authored-by: Frank Chen <frankchen@apache.org>
|
Thank you @santosh-d3vpl3x for your first contribution. |
|
Going to close and reopen this to try to retrigger a Travis CI run. It's using an older version of |
|
@santosh-d3vpl3x Could you merge master into your branch, please? I think for Travis CI to run successfully the branch needs to pull in a |
It looks stuck! |
There's a queue sometimes, since we share one Travis CI account across all Apache projects. Looks like the job is running now! |
6 participants
Fixes #12064.
Description
This PR has: