Skip to content

Remove dependency on jvm-attach.#12989

Merged
vogievetsky merged 1 commit intoapache:masterfrom
gianm:no-jstatdata
Aug 29, 2022
Merged

Remove dependency on jvm-attach.#12989
vogievetsky merged 1 commit intoapache:masterfrom
gianm:no-jstatdata

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Aug 27, 2022

This dependency was no longer needed after #12481, but remained because
it was used for a (now useless) test. This patch removes the test and
the dependency.

This dependency was no longer needed after apache#12481, but remained because
it was used for a (now useless) test. This patch removes the test and
the dependency.
Copy link
Copy Markdown
Contributor

@cryptoe cryptoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 non binding

@vogievetsky vogievetsky merged commit 9eb20e5 into apache:master Aug 29, 2022
599166320 pushed a commit to 599166320/apache-druid that referenced this pull request Aug 30, 2022
This dependency was no longer needed after apache#12481, but remained because
it was used for a (now useless) test. This patch removes the test and
the dependency.
@gianm gianm deleted the no-jstatdata branch September 23, 2022 19:26
@kfaraz kfaraz added this to the 25.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants