Skip to content

Fix QueryContext race condition #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Sep 12, 2022
Merged

Fix QueryContext race condition #13049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sql/src/main/java/org/apache/druid/sql/avatica/DruidConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public DruidJdbcStatement createStatement(SqlStatementFactory sqlStatementFactor
final DruidJdbcStatement statement = new DruidJdbcStatement(
connectionId,
statementId,
context,
context.copy(),
sqlStatementFactory
);

Expand All @@ -109,7 +109,7 @@ public DruidJdbcStatement createStatement(SqlStatementFactory sqlStatementFactor

public DruidJdbcPreparedStatement createPreparedStatement(
SqlStatementFactory sqlStatementFactory,
SqlQueryPlus sqlRequest,
SqlQueryPlus sqlQueryPlus,
final long maxRowCount)
{
final int statementId = statementCounter.incrementAndGet();
Expand All @@ -127,7 +127,7 @@ public DruidJdbcPreparedStatement createPreparedStatement(

@SuppressWarnings("GuardedBy")
final PreparedStatement statement = sqlStatementFactory.preparedStatement(
sqlRequest.withContext(context)
sqlQueryPlus.withContext(context.copy())
);
final DruidJdbcPreparedStatement jdbcStmt = new DruidJdbcPreparedStatement(
connectionId,
Expand Down