Make http options the default configurations#13092
Conversation
| "druid.indexer.runner.type", | ||
| Key.get(TaskRunnerFactory.class), | ||
| Key.get(ForkingTaskRunnerFactory.class) | ||
| Key.get(HttpRemoteTaskRunnerFactory.class) |
There was a problem hiding this comment.
With this change, I think there's no need for druid.indexer.runner.type=httpRemote in all the bundled configs anymore. Could you try removing that line and see if everything still works OK?
There was a problem hiding this comment.
Done, thanks!
|
How will the upgrade look when people go from zk-based task management to HTTP-based task management considering most of the people running their clusters would be using default values? IMHO we should tag release notes on this PR as well. |
|
Upgrade should not be a concern for the loadqueue peon type and the server inventory view mode being changed to "http" as these take effect when the coordinator is restarted. The respective endpoints are already exposed by the historical, so the change should be seamless. Task management should be fine too if the upgrade order is maintained i.e. MM/indexer before overlord. An upgraded middle manager would be listening on HTTP for new tasks but the overlord would start sending HTTP task assignments only when it is upgraded too. cc: @cryptoe |
|
@AmatyaAvadhanula , there seems to be some coverage failure. I think it can be remedied if you add a line to verify the loadqueue peon type in |
|
@kfaraz thank you for the review! I've added the test |
4 participants
Makes http configurations the default configurations
Description
Druid uses Zookeeper dependent options as the default.
Http based options have been tried and tested and are now the recommended options
TaskRunner : local -> httpRemote
LoadQueue : curator -> http
ServerInventoryView : batch -> http
This PR has: