fix nested column thread safety issue for 24.0.1#13267
Merged
abhishekagarwal87 merged 1 commit intoapache:24.0.1from Oct 28, 2022
Merged
fix nested column thread safety issue for 24.0.1#13267abhishekagarwal87 merged 1 commit intoapache:24.0.1from
abhishekagarwal87 merged 1 commit intoapache:24.0.1from
Conversation
imply-cheddar
approved these changes
Oct 27, 2022
Comment on lines
+165
to
+166
| indexer.mergeFields(mergedFields); | ||
| return indexer.getSortedCollector(); |
Contributor
There was a problem hiding this comment.
This change is just general refactoring and not actually functionally meaningful, right? Just validating my understanding
Member
Author
There was a problem hiding this comment.
yep, made writing the test easier and the direct field access was kind of ugly
abhishekagarwal87
approved these changes
Oct 28, 2022
Member
|
@clintropolis it looks like integration tests are still failing in the 24.0.1 branch. We might want to check if there is something non-deterministic or not. |
Member
Author
hmm, these actually look unrelated to my fix, but maybe worth looking into I think maybe #13049 is the fix |
Member
Author
|
created #13281 to backport that fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smaller footprint version of fix #13265 for 24.0.1, this just fixes the
TypeStrategyto use positional reads