RTR: Dedupe items in getKnownTasks.#13273
Merged
gianm merged 1 commit intoapache:masterfrom Oct 28, 2022
Merged
Conversation
Fixes a problem where the tasks API in OverlordResource would complain about duplicate keys in the map it's building.
kfaraz
approved these changes
Oct 28, 2022
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for the fix!
So I guess there would be duplicates if say a task moves from "PENDING" to "RUNNING" and the running set is updated but the the pending set is still not updated?
Contributor
Author
The sets can be updated while |
kfaraz
pushed a commit
to kfaraz/druid
that referenced
this pull request
Oct 28, 2022
Fixes a problem where the tasks API in OverlordResource would complain about duplicate keys in the map it's building.
kfaraz
added a commit
that referenced
this pull request
Oct 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem where the tasks API in OverlordResource would complain about duplicate keys in the map it's building.