Skip to content

Improve performance for ReadableInputStreamFrameChannel#13373

Merged
cryptoe merged 2 commits intoapache:masterfrom
rohangarg:readable_input_stream
Nov 18, 2022
Merged

Improve performance for ReadableInputStreamFrameChannel#13373
cryptoe merged 2 commits intoapache:masterfrom
rohangarg:readable_input_stream

Conversation

@rohangarg
Copy link
Copy Markdown
Member

Moves away from sleep wait in ReadableInputStreamFrameChannel to wait/notify model.
This improves the performance for DurableStorageOutputChannel by around 10x on local storage backed durable output channel.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@rohangarg rohangarg added the Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 label Nov 16, 2022
Copy link
Copy Markdown
Contributor

@cryptoe cryptoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rohangarg for the fix.

@cryptoe cryptoe merged commit 5b625ce into apache:master Nov 18, 2022
@kfaraz kfaraz added this to the 25.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants