nested column support for ORC#13375
Merged
clintropolis merged 2 commits intoapache:masterfrom Nov 18, 2022
Merged
Conversation
paul-rogers
approved these changes
Nov 17, 2022
Contributor
paul-rogers
left a comment
There was a problem hiding this comment.
The code and tests look fine. Can't comment on the detailed semantics. I'm trusting that the extensive unit tests prove that the semantics are valid.
3 tasks
This was referenced Dec 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Druid nested columns and JSON functions to ORC input files, fixing up the flattening conversion machinery to handle nested outputs, and fixing a few other conversion related bugs.
Release note
ORC input files are now supported by Druid nested columns and associated JSON transform functions.
This PR has: