Skip to content

Web console: streaming json input format specifics #13381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clintropolis merged 2 commits into from
Nov 18, 2022
Merged

Web console: streaming json input format specifics #13381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77034a8
streaming json input format specifics
vogievetsky Nov 17, 2022
8e4a0a4
goodies
vogievetsky Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web-console/src/components/show-json/__snapshots__/show-json.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ exports[`ShowJson matches snapshot 1`] = `
<span
class="bp4-button-text"
>
Save
Download
</span>
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/components/show-json/show-json.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const ShowJson = React.memo(function ShowJson(props: ShowJsonProps) {
{downloadFilename && (
<Button
disabled={jsonState.loading}
text="Save"
text="Download"
minimal
onClick={() => downloadFile(jsonValue, 'json', downloadFilename)}
/>
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/components/show-log/__snapshots__/show-log.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`ShowLog describe show log 1`] = `
<span
class="bp4-button-text"
>
Save
Download
</span>
</a>
<button
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/components/show-log/show-log.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class ShowLog extends React.PureComponent<ShowLogProps, ShowLogState> {
<ButtonGroup className="right-buttons">
{downloadFilename && (
<AnchorButton
text="Save"
text="Download"
minimal
download={downloadFilename}
href={UrlBaser.base(endpoint)}
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/components/show-value/__snapshots__/show-value.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exports[`ShowValue matches snapshot 1`] = `
<span
class="bp4-button-text"
>
Save
Download
</span>
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/components/show-value/show-value.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const ShowValue = React.memo(function ShowValue(props: ShowValueProps) {
)}
{downloadFilename && (
<Button
text="Save"
text="Download"
minimal
onClick={() => downloadFile(jsonValue, 'json', downloadFilename)}
/>
Expand Down
2 changes: 1 addition & 1 deletion ...logs/segments-table-action-dialog/__snapshots__/segment-table-action-dialog.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ exports[`SegmentTableActionDialog matches snapshot 1`] = `
<span
class="bp4-button-text"
>
Save
Download
</span>
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion ...supervisor-table-action-dialog/__snapshots__/supervisor-table-action-dialog.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ exports[`SupervisorTableActionDialog matches snapshot 1`] = `
<span
class="bp4-button-text"
>
Save
Download
</span>
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion ...src/dialogs/task-table-action-dialog/__snapshots__/task-table-action-dialog.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ exports[`TaskTableActionDialog matches snapshot 1`] = `
<span
class="bp4-button-text"
>
Save
Download
</span>
</button>
<button
Expand Down
8 changes: 2 additions & 6 deletions web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,8 @@ export function getSpecType(spec: Partial<IngestionSpec>): IngestionType {
);
}

export function isTask(spec: Partial<IngestionSpec>) {
const type = String(getSpecType(spec));
return (
type.startsWith('index_') ||
oneOf(type, 'index', 'compact', 'kill', 'append', 'merge', 'same_interval_merge')
);
export function isStreamingSpec(spec: Partial<IngestionSpec>): boolean {
return oneOf(getSpecType(spec), 'kafka', 'kinesis');
}

export function isDruidSource(spec: Partial<IngestionSpec>): boolean {
Expand Down
Loading