Skip to content

JvmMonitor: Report jvm/gc/cpu in nanos. #13383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishekagarwal87 merged 1 commit into from
Nov 18, 2022
Merged

JvmMonitor: Report jvm/gc/cpu in nanos. #13383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/src/main/java/org/apache/druid/java/util/metrics/JvmMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ private class GcGenerationCollector
private final GarbageCollectorMXBean gcBean;

private long lastInvocations = 0;
private long lastCpuNanos = 0;
private long lastCpuMillis = 0;

private static final String GC_YOUNG_GENERATION_NAME = "young";
private static final String GC_OLD_GENERATION_NAME = "old";
Expand Down Expand Up @@ -268,10 +268,10 @@ void emit(ServiceEmitter emitter, Map<String, String[]> dimensions)
emitter.emit(builder.build("jvm/gc/count", newInvocations - lastInvocations));
lastInvocations = newInvocations;

long newCpuNanos = gcBean.getCollectionTime();
emitter.emit(builder.build("jvm/gc/cpu", newCpuNanos - lastCpuNanos));
lastCpuNanos = newCpuNanos;

// getCollectionTime is in milliseconds; we report jvm/gc/cpu in nanoseconds.
long newCpuMillis = gcBean.getCollectionTime();
emitter.emit(builder.build("jvm/gc/cpu", (newCpuMillis - lastCpuMillis) * 1_000_000L));
lastCpuMillis = newCpuMillis;
}
}

Expand Down