Add MetricsVerifier to simplify verification of metric values in tests#13442
Merged
kfaraz merged 2 commits intoapache:masterfrom Nov 28, 2022
Merged
Add MetricsVerifier to simplify verification of metric values in tests#13442kfaraz merged 2 commits intoapache:masterfrom
kfaraz merged 2 commits intoapache:masterfrom
Conversation
AmatyaAvadhanula
approved these changes
Nov 28, 2022
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
LGTM @kfaraz. +1 after builds pass
Contributor
Author
|
Thanks for the review, @AmatyaAvadhanula! |
kfaraz
added a commit
to kfaraz/druid
that referenced
this pull request
Nov 28, 2022
kfaraz
added a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
MetricsVerifierMetricsVerifiermethodsThis PR has: