Skip to content

Fix compile error in MSQSelectTest.#13456

Merged
cheddar merged 1 commit intoapache:masterfrom
gianm:msq-fix-test-compile
Nov 29, 2022
Merged

Fix compile error in MSQSelectTest.#13456
cheddar merged 1 commit intoapache:masterfrom
gianm:msq-fix-test-compile

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Nov 29, 2022

Midair collision between #13366 and #13398.

@gianm gianm added Bug Development Blocker Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Nov 29, 2022
@cheddar
Copy link
Copy Markdown
Contributor

cheddar commented Nov 29, 2022

Failure in CompactionTest that looks flaky, the change in this PR to make things actually compile shouldn't suddenly cause code that is not even using the changed line to suddenly start a death spiral.

LGTM cannot pass because the base commit cannot compile. Merging anyway.

@cheddar cheddar merged commit 50963ed into apache:master Nov 29, 2022
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Bug Development Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants