Skip to content

docs: add a link for the Druid SQL tutorial #13468

Merged
techdocsmith merged 14 commits intoapache:masterfrom
ektravel:jupyter-nb-sql-tutorial
Feb 22, 2023
Merged

docs: add a link for the Druid SQL tutorial #13468
techdocsmith merged 14 commits intoapache:masterfrom
ektravel:jupyter-nb-sql-tutorial

Conversation

@ektravel
Copy link
Copy Markdown
Contributor

@ektravel ektravel commented Nov 30, 2022

Description

This PR add a link for the Druid SQL tutorial that uses Jupyter to the tutorial-jupyter-index.md file.

This PR can be merged after PR 13465, PR 13342, and PR 13588.

This PR has:

  • [ x ] been self-reviewed.

Copy link
Copy Markdown
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

For reference, the diff between this and #13342 is that 13342 only includes the link to the API tutorial Jupyter notebook. This one includes the API tutorial and the SQL ( line 65 in README.md and line 68 in tutorial-jupyter-index.md. This was done in a separate PR rather than a commit to 13342 to make managing dependencies between PRs easier.

Comment thread docs/tutorials/tutorial-jupyter-index.md Outdated
@techdocsmith
Copy link
Copy Markdown
Contributor

techdocsmith commented Feb 9, 2023

@ektravel , do you want to remove the lines referring to Segment sizing and partitioning so we can merge this PR? Thanks!

I fixed a merge conflict and also changed the bullet formatting for the start commands to avoid going too deep w/ bullets

@ektravel
Copy link
Copy Markdown
Contributor Author

ektravel commented Feb 9, 2023

@techdocsmith I've removed the lines referring to Segment sizing and partitioning. Thank you for fixing the merge conflict.

Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit 1595653 into apache:master Feb 22, 2023
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants