Better error message when theta_sketch_intersect is used on scalar expression#13508
Merged
kfaraz merged 2 commits intoapache:masterfrom Dec 7, 2022
Merged
Conversation
kfaraz
reviewed
Dec 6, 2022
| ) | ||
| { | ||
| plannerContext.setPlanningError("%s can only be used on aggregates. " + | ||
| "It cannot be used directly on a column or or on a scalar expression.", getFunctionName()); |
Contributor
There was a problem hiding this comment.
typo: double or
Since the error message is specific to theta sketch, maybe we can mention the exact type of arguments this function expects, rather than mentioning what it cannot accept.
Contributor
Author
There was a problem hiding this comment.
the type check is already done. This tells the user that they are trying to use the function as an expression while its only available as a post aggregator.
Contributor
There was a problem hiding this comment.
Ah, okay. Thanks for the clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has: