Web console: improve compaction status display#13523
Web console: improve compaction status display#13523vogievetsky merged 3 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
LGTM. I agree on making this clearer by indicating that there are segments skipped. One thing to keep in mind, in addition to the segments skipped by the skipOffsetFromLatest, segments can be skipped if the size is greater than inputSegmentSizeBytes. I believe the default of inputSegmentSizeBytes was recently change to MAX Long but someone could still have it set (to less than MAX long) and use to skip segments. If this is the case, then segmentCountSkipped would include both the segments skipped by inputSegmentSizeBytes and skipOffsetFromLatest.
|
Thank you for the comment @maytasm ! I added an extra state:
Also this bonus callout:
|
|
I think if the config for inputSegmentSizeBytes is unset/default/Max Long then we can skip mentioning about inputSegmentSizeBytes in the text (like what you originally had). This is because if it is unset or default it is set to Max Long and no segment can be larger than Max Long. |
|
that is exactly what I did, see test here: https://github.com/apache/druid/pull/13523/files#diff-1ffc9967b15ea72efe7a9da75c4b555c2f107ed4639e7ff497f6a1691a3c8b8aR127 |
* improve compaction status display * even more accurate * fix snapshot
* Web console: add arrayOfDoublesSketch and other small fixes (#13486) * add padding and keywords * add arrayOfDoubles * Update docs/development/extensions-core/datasketches-tuple.md Co-authored-by: Charles Smith <techdocsmith@gmail.com> * Update docs/development/extensions-core/datasketches-tuple.md Co-authored-by: Charles Smith <techdocsmith@gmail.com> * Update docs/development/extensions-core/datasketches-tuple.md Co-authored-by: Charles Smith <techdocsmith@gmail.com> * Update docs/development/extensions-core/datasketches-tuple.md Co-authored-by: Charles Smith <techdocsmith@gmail.com> * Update docs/development/extensions-core/datasketches-tuple.md Co-authored-by: Charles Smith <techdocsmith@gmail.com> * partiton int * fix docs Co-authored-by: Charles Smith <techdocsmith@gmail.com> * Web console: improve compaction status display (#13523) * improve compaction status display * even more accurate * fix snapshot * MSQ: Improve TooManyBuckets error message, improve error docs. (#13525) 1) Edited the TooManyBuckets error message to mention PARTITIONED BY instead of segmentGranularity. 2) Added error-code-specific anchors in the docs. 3) Add information to various error codes in the docs about common causes and solutions. * update error anchors (#13527) * update snapshot Co-authored-by: Charles Smith <techdocsmith@gmail.com> Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
2 participants
This PR is attempting to resolve a UX confusion.
The issue: sometimes the datasources tab shows a datasource to be "Fully compacted" when in fact there are segments that should be compacted. I believe that the cause of this (or at least one of the causes) is that there are segments in the "skipOffsetFromLatest" interval and the user does not realize that they are getting skipped (by design).
Solution, if there are skipped segments, instead of rendering the status as "Fully compacted" render it as "Fully compacted (except the last P1D of data, 24 segments skipped)` where P1D is the skipOffsetFromLatest setting and 24 is the number of segments skipped. This simply makes the label more truthful and potentially less confusing.
Before:
After:
After with expanded column:
The column width of the
Compactioncolumn has been expanded slightly to accommodate as tantalizing(except...I believe this change is a no-op since all these properties would be zero or non-zero together but it does not hurt to be more robust: