Document shouldFinalize for sketches that have the parameter#13524
Merged
vtlim merged 7 commits intoapache:masterfrom Dec 17, 2022
Merged
Document shouldFinalize for sketches that have the parameter#13524vtlim merged 7 commits intoapache:masterfrom
vtlim merged 7 commits intoapache:masterfrom
Conversation
kfaraz
reviewed
Dec 9, 2022
Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
techdocsmith
requested changes
Dec 16, 2022
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
Requested some changes for style and clarity
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
vtlim
added a commit
to vtlim/druid
that referenced
this pull request
Dec 17, 2022
…13524) Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> Co-authored-by: Charles Smith <techdocsmith@gmail.com>
kfaraz
pushed a commit
that referenced
this pull request
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
shouldFinalizeparameter for HLL, Theta, and quantiles sketches.Relates to #13247.
This PR has: